Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Sass files and @include #107

Open
glen-84 opened this issue Apr 15, 2016 · 0 comments
Open

Problem with Sass files and @include #107

glen-84 opened this issue Apr 15, 2016 · 0 comments

Comments

@glen-84
Copy link

glen-84 commented Apr 15, 2016

Sass (scss) files use mixins which are included using @include. If you comment-out an include, you end up with:

// @include foundation-table;

... and preprocess tries to include this as a file.

Some options that I can think of:

  1. Don't match when it contains or ends with a semi-colon.
    • Technically, a semi-colon is valid in a file name, so this isn't ideal.
  2. Don't match unless it contains a period (.).
    • A file without an extension is also technically valid, so this is also not ideal.
  3. Use a different syntax, like #include or !include.
    • This breaks the general pattern of using @, however this may be a good thing, because Sass already has @include syntax, and in fact that is valid in PHP as well.

What do you think? Do we need semi-colons in file paths/names? Do we need files without extensions? Would it make sense to make the @ prefix customizable? Any other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant