Fixed DOMContent loaded, Updated test to account for document.readySt… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orditeck
suggested changes
Jul 8, 2019
| @@ -1,4 +1,4 @@ | |||
| /*! animate.js v1.4.0 | (c) 2018 Josh Johnson | https://github.com/jshjohnson/animate.js */ | |||
| /*! animate.js v1.4.1 | (c) 2018 Josh Johnson | https://github.com/jshjohnson/animate.js */ | |||
|
This PR should also be rebased. |
|
I've rewritten this library in TypeScript and have included your fix :) thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
This will cover use case where scripts are included with
asyncas in -<script src="some/bundle.js" async></script>OR loaded inline. - As there is now a check fordocument.readyState.If there is ever a need to disable this loading immediately on initialisation - The
options.onLoadflag can be set tofalsefor manual control.Sorry to stalk you @jshjohnson - Just building some street cred and I really your vanilla js packages! 👍