Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route of the demo page without "/" symbol #275

Open
alexey-yarmosh opened this issue Jan 9, 2023 · 4 comments
Open

Fix route of the demo page without "/" symbol #275

alexey-yarmosh opened this issue Jan 9, 2023 · 4 comments
Labels
good first issue help wanted

Comments

@alexey-yarmosh
Copy link
Member

alexey-yarmosh commented Jan 9, 2023 •
edited

Currently we can access demo page using: https://api.globalping.io/demo/
Same path without slash at the end (https://api.globalping.io/demo) responds with 404 Not Found.

Need to reconfigure @koa/router so the page is accessible from both urls.
@Abuka-Victor
Copy link

Hi, can I take this on?

@alexey-yarmosh
Copy link
Member Author

Sure, you are welcome)

@Abuka-Victor
Copy link

Thank you, I will reach out if I have questions navigating

@MartinKolarik
Copy link
Member

This is very much intentional for the API routes so if it's changed, it must be only for the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinKolarik @alexey-yarmosh @Abuka-Victor