Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre- and post-build hooks correctly #41

Open
jscrane opened this issue Jul 19, 2023 · 1 comment
Open

Support pre- and post-build hooks correctly #41

jscrane opened this issue Jul 19, 2023 · 1 comment

Comments

@jscrane
Copy link
Owner

jscrane commented Jul 19, 2023

See the specification.

This is required for arduino-esp32 2.0.10.

`# Set -DARDUINO_CORE_BUILD only on core file compilation
file_opts.path={build.path}/file_opts
recipe.hooks.prebuild.set_core_build_flag.pattern=bash -c ": > {file_opts.path}"
recipe.hooks.core.prebuild.set_core_build_flag.pattern=bash -c "echo '-DARDUINO_CORE_BUILD' > {file_opts.path}"
recipe.hooks.core.postbuild.set_core_build_flag.pattern=bash -c ": > {file_opts.path}"

recipe.hooks.prebuild.set_core_build_flag.pattern.windows=cmd /c type nul > {file_opts.path}
recipe.hooks.core.prebuild.set_core_build_flag.pattern.windows=cmd /c echo "-DARDUINO_CORE_BUILD" > {file_opts.path}
recipe.hooks.core.postbuild.set_core_build_flag.pattern.windows=cmd /c type nul > {file_opts.path}
`

@jscrane
Copy link
Owner Author

jscrane commented Jul 28, 2023

Current status: have implemented prebuild and prelink hooks correctly. This is sufficient to support arduino-esp32 2.0.11.

The core.prebuild hook above isn't handled but this doesn't seem to matter.

Windows-override for these hooks isn't implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant