Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to get vID from orginalID or allow originalID to be used in RemoveTaskItem #376

Open
Taffaz opened this issue Jan 31, 2024 · 3 comments

Comments

@Taffaz
Copy link

Taffaz commented Jan 31, 2024

Is your feature request related to a problem? Please describe.
Following import using JSGantt.parseXMLString the id provided in the XML is not the same as that returned by GetID. When trying to remove a task using the XML provided value the code doesn't work as it is looking at the new ID.

Describe the solution you'd like
Either a method that returns the new ID from the originalID (which is accessible) or allow originalID to be used in RemoveTaskItem and potentially other functions that use ID.

Describe alternatives you've considered
Keep the IDs the same as the XML input so there is no difference between the two

Additional context
I am happy to make this change as I modified the source myself to get the functionality I needed.

@Taffaz
Copy link
Author

Taffaz commented Feb 1, 2024

In my local version of the code I resolved this by adding a function called GetIdFromOriginal that returned general_utils_1.hashKey(pId)

@mariohmol
Copy link
Collaborator

Hi @Taffaz , thanks for the feedback. could you please provide a PR ?

@JeremyHornet900
Copy link

I guess the getOriginalID was meant for this, when you go to the jsgantt.js file from line 3800 something you can see all the get functions available and then all the set functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants