Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infrastructure: update "engines" to node>=10.9 #2058

Closed
wants to merge 1 commit into from
Closed

infrastructure: update "engines" to node>=10.9 #2058

wants to merge 1 commit into from

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented Dec 7, 2020 •
edited

This PR fixes #2056

  • package.json engines is updated to node>=10.9
  • github actions are updated to by default use 14.x instead of 12.x (or 10.x)
  • move node 8.x test runs to legacy, and remove 6.x from legacy
  • ts compile target is remained as ES5, as escomplex-js depends on esprima 1 which doesn't support ES6. While lib is changed to ES6, as Node 10.9+ already has full ES6 support, see https://node.green/

@ljqx ljqx changed the title infrastructure: update "engines" to node>=10.4 infrastructure: update "engines" to node>=10.9 Dec 7, 2020
Base automatically changed from master to main March 16, 2021 16:37
@ariya
Copy link
Contributor

ariya commented Jun 11, 2021

Superseded by #2086.

@ariya ariya closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

infrastructure: update "engines" to node>=10.9
2 participants
@ljqx @ariya