Fails to parse 'Spread' syntax: Unexpected token ... #2034

rob4629 · 2020-09-02T22:25:29Z

Steps to reproduce

I'm using the ES2018 syntax in my code, and Esprima is failing to parse the "spread" syntax (...), for creating iterables and concatenating objects.

// Spread syntax:
const obj1 = { key: "value"};
const obj2 = { ...obj1, key2: "value"};

esprima.parse(obj2);

Expected output

I would expect the Spread syntax to be correctly parsed.

Actual output

Here's a demo link to the current issue being faced

Here's the full stack trace:

Unexpected token ...
      at ErrorHandler.constructError (node_modules/esprima/dist/esprima.js:5012:22)
      at ErrorHandler.createError (node_modules/esprima/dist/esprima.js:5028:27)
      at Parser.unexpectedTokenError (node_modules/esprima/dist/esprima.js:1985:39)
      at Parser.throwUnexpectedToken (node_modules/esprima/dist/esprima.js:1995:21)
      at Parser.parseObjectPropertyKey (node_modules/esprima/dist/esprima.js:2499:33)
      at Parser.parseObjectProperty (node_modules/esprima/dist/esprima.js:2534:25)
      at Parser.parseObjectInitializer (node_modules/esprima/dist/esprima.js:2602:35)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parsePrimaryExpression (node_modules/esprima/dist/esprima.js:2354:38)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseLeftHandSideExpressionAllowCall (node_modules/esprima/dist/esprima.js:2899:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseUpdateExpression (node_modules/esprima/dist/esprima.js:3004:26)
      at Parser.parseUnaryExpression (node_modules/esprima/dist/esprima.js:3048:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseExponentiationExpression (node_modules/esprima/dist/esprima.js:3054:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseBinaryExpression (node_modules/esprima/dist/esprima.js:3089:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseConditionalExpression (node_modules/esprima/dist/esprima.js:3141:26)
      at Parser.parseAssignmentExpression (node_modules/esprima/dist/esprima.js:3250:26)
      at Parser.isolateCoverGrammar (node_modules/esprima/dist/esprima.js:2269:37)
      at Parser.parseLexicalBinding (node_modules/esprima/dist/esprima.js:3425:34)
      at Parser.parseBindingList (node_modules/esprima/dist/esprima.js:3439:27)
      at Parser.parseLexicalDeclaration (node_modules/esprima/dist/esprima.js:3461:34)
      at Parser.parseStatementListItem (node_modules/esprima/dist/esprima.js:3376:39)
      at Parser.parseFunctionSourceElements (node_modules/esprima/dist/esprima.js:4195:29)
      at Parser.parseAssignmentExpression (node_modules/esprima/dist/esprima.js:3286:38)
      at Parser.isolateCoverGrammar (node_modules/esprima/dist/esprima.js:2269:37)
      at Parser.parseArguments (node_modules/esprima/dist/esprima.js:2807:27)
      at Parser.parseLeftHandSideExpressionAllowCall (node_modules/esprima/dist/esprima.js:2913:76)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseUpdateExpression (node_modules/esprima/dist/esprima.js:3004:26)
      at Parser.parseUnaryExpression (node_modules/esprima/dist/esprima.js:3048:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseExponentiationExpression (node_modules/esprima/dist/esprima.js:3054:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseBinaryExpression (node_modules/esprima/dist/esprima.js:3089:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseConditionalExpression (node_modules/esprima/dist/esprima.js:3141:26)
      at Parser.parseAssignmentExpression (node_modules/esprima/dist/esprima.js:3250:26)
      at Parser.isolateCoverGrammar (node_modules/esprima/dist/esprima.js:2269:37)
      at Parser.parseExpression (node_modules/esprima/dist/esprima.js:3341:26)
      at Parser.parseLabelledStatement (node_modules/esprima/dist/esprima.js:3996:26)
      at Parser.parseStatement (node_modules/esprima/dist/esprima.js:4122:97)
      at Parser.parseStatementListItem (node_modules/esprima/dist/esprima.js:3393:31)
      at Parser.parseFunctionSourceElements (node_modules/esprima/dist/esprima.js:4195:29)
      at Parser.parseFunctionExpression (node_modules/esprima/dist/esprima.js:4408:26)
      at Parser.parsePrimaryExpression (node_modules/esprima/dist/esprima.js:2380:38)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseLeftHandSideExpressionAllowCall (node_modules/esprima/dist/esprima.js:2899:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseUpdateExpression (node_modules/esprima/dist/esprima.js:3004:26)
      at Parser.parseUnaryExpression (node_modules/esprima/dist/esprima.js:3048:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseExponentiationExpression (node_modules/esprima/dist/esprima.js:3054:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseBinaryExpression (node_modules/esprima/dist/esprima.js:3089:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseConditionalExpression (node_modules/esprima/dist/esprima.js:3141:26)
      at Parser.parseAssignmentExpression (node_modules/esprima/dist/esprima.js:3250:26)
      at Parser.isolateCoverGrammar (node_modules/esprima/dist/esprima.js:2269:37)
      at Parser.parseArguments (node_modules/esprima/dist/esprima.js:2807:27)
      at Parser.parseLeftHandSideExpressionAllowCall (node_modules/esprima/dist/esprima.js:2913:76)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseUpdateExpression (node_modules/esprima/dist/esprima.js:3004:26)
      at Parser.parseUnaryExpression (node_modules/esprima/dist/esprima.js:3048:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseExponentiationExpression (node_modules/esprima/dist/esprima.js:3054:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseBinaryExpression (node_modules/esprima/dist/esprima.js:3089:26)
      at Parser.inheritCoverGrammar (node_modules/esprima/dist/esprima.js:2285:37)
      at Parser.parseConditionalExpression (node_modules/esprima/dist/esprima.js:3141:26)
      at Parser.parseAssignmentExpression (node_modules/esprima/dist/esprima.js:3250:26)
      at Parser.isolateCoverGrammar (node_modules/esprima/dist/esprima.js:2269:37)
      at Parser.parseExpression (node_modules/esprima/dist/esprima.js:3341:26)
      at Parser.parseLabelledStatement (node_modules/esprima/dist/esprima.js:3996:26)
      at Parser.parseStatement (node_modules/esprima/dist/esprima.js:4122:97)
      at Parser.parseStatementListItem (node_modules/esprima/dist/esprima.js:3393:31)
      at Parser.parseModule (node_modules/esprima/dist/esprima.js:4715:29)
      at parse (node_modules/esprima/dist/esprima.js:122:38)

Relevant references

You can see the Spread syntax here.

The text was updated successfully, but these errors were encountered:

fzxs8 · 2021-01-27T12:58:41Z

这么长时间了还没修复!

Jamby93 · 2021-04-13T08:15:41Z

Actually, the spread operator seems to be correctly parsed in almost every case (function parameters, array initialization). It is even present in the parseObjectInitializer at line 936 so I think it should be working, but as OP found out, it actually breaks with Unexpected token inside parseObjectPropertyKey.
I solved by adding a single else inside the parseObjectPropertyKey, just before the last else:
else if (this.match('...')) { return this.parseSpreadElement(); }

I'm not entirely sure why the parseSpreadElement handled in parseObjectInitializer isn't triggering, but at least with this fix I was able to proceed with parsing of our files.

0x00C5 · 2021-11-05T17:06:12Z

The solution from @Jamby93 worked for me. If you want to patch the node_modules source directly without having to compile the source, look for the following line (currently line 2511 in dist/esprima.js):

Parser.prototype.parseObjectProperty = function (hasProto) {

GrayYoung · 2021-12-31T05:16:51Z

这么长时间了还没修复!

I upgraded bootstrap to V5, suffering the same problem, feeling so bad.

Meir017 · 2021-12-31T05:51:11Z

@jogibear9988 is this supported in https://github.com/node-projects/esprima-next ?

jogibear9988 · 2021-12-31T10:34:30Z

don't know. test it, if it does not work, create an issue and I will fix

jogibear9988 · 2022-01-01T11:27:35Z

@Meir017 @GrayYoung
I've tried, this works in my fork esprima-next

mjaggard · 2022-02-10T10:28:58Z

For anyone else struggling with this, one option is to run Babel on the offending file(s)

rob4629 mentioned this issue Sep 2, 2020

Latest version (1.1.0) fails to parse the JS Spread syntax vkarpov15/acquit#23

Open

This was referenced Aug 28, 2021

ES6 Spread syntax not work requirejs/r.js#971

Closed

ES6 Object Spread syntax not work requirejs/r.js#998

Open

This was referenced Nov 5, 2021

Issue with Spread Operator Inside JSON #1927

Open

Object Rest/Spread Properties #1588

Closed

Spread in objects doesn't parse #1862

Closed

charleshtrenholm mentioned this issue Dec 16, 2021

Remove object spread syntax that esprima 4.0.1 doesn't like kbase/narrative#2657

Merged

15 tasks

shurintou mentioned this issue Jun 19, 2023

Esprima doesn't support spread syntax shurintou/count-function-lines#1

Closed

JosiasAurel mentioned this issue Feb 27, 2024

upgrade esprima to esprima-next and fixing spread operator not working hackclub/sprig#1455

Merged

denolfe mentioned this issue Apr 11, 2024

fix(cpa): ast parse error handling payloadcms/payload#5793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fails to parse 'Spread' syntax: Unexpected token ... #2034

Fails to parse 'Spread' syntax: Unexpected token ... #2034

rob4629 commented Sep 2, 2020 •

edited

fzxs8 commented Jan 27, 2021

Jamby93 commented Apr 13, 2021

0x00C5 commented Nov 5, 2021

GrayYoung commented Dec 31, 2021

Meir017 commented Dec 31, 2021

jogibear9988 commented Dec 31, 2021

jogibear9988 commented Jan 1, 2022

mjaggard commented Feb 10, 2022

Fails to parse 'Spread' syntax: Unexpected token ... #2034

Fails to parse 'Spread' syntax: Unexpected token ... #2034

Comments

rob4629 commented Sep 2, 2020 • edited

Steps to reproduce

Expected output

Actual output

Relevant references

fzxs8 commented Jan 27, 2021

Jamby93 commented Apr 13, 2021

0x00C5 commented Nov 5, 2021

GrayYoung commented Dec 31, 2021

Meir017 commented Dec 31, 2021

jogibear9988 commented Dec 31, 2021

jogibear9988 commented Jan 1, 2022

mjaggard commented Feb 10, 2022

rob4629 commented Sep 2, 2020 •

edited