Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortify SCA: Code Injection . #554

Open
Raolibec opened this issue Aug 3, 2018 · 7 comments
Open

Fortify SCA: Code Injection . #554

Raolibec opened this issue Aug 3, 2018 · 7 comments

Comments

@Raolibec
Copy link

Raolibec commented Aug 3, 2018

Please review Instructions for Reporting a Bug.

Description:

I have no idea about whether it has been fixed in later versions. but the code scan is not passed.

Expected Behavior:

Actual behavior:

Source: jquery.form.js:812 Read xhr.responseXML()
810 var ct = xhr.getResponseHeader('content-type') || '',
811 xml = type === 'xml' || !type && ct.indexOf('xml') >= 0,
812 data = xml ? xhr.responseXML : xhr.responseText;
813
814 if (xml && data.documentElement.nodeName === 'parsererror') {
Sink: jquery.form.js:781 setTimeout() 779
780 // clean up
781 setTimeout(function() {
782 if (!s.iframeTarget) {
783 $io.remove();

Versions:

jqform:3.51

@roderickforsythe
Copy link

The latest release ( version: 4.2.2) still has this issue being reported by Fortify... anyone make any progress?

@kevindb
Copy link
Contributor

kevindb commented Mar 17, 2019

I'm not sure what code scan you're referring to. Can you provide more information on the vulnerability?
Even better, please open a pull request with the necessary code changes.

@Raolibec
Copy link
Author

i tried to get some more information about the code scan report.

There is the issue founded by Fortify:

jquery.form.js, line 781 (Dynamic Code Evaluation: Code Injection)
Fortify Priority: Critical
Folder: Critical
Kingdom: Input Validation and Representation
Abstract: jquery.form.js 781

Source: jquery.form.js:812 Read xhr.responseXML()

810` var ct = xhr.getResponseHeader('content-type') || '',
811 xml = type === 'xml' || !type && ct.indexOf('xml') >= 0,
812 data = xml ? xhr.responseXML : xhr.responseText;
813
814 if (xml && data.documentElement.nodeName === 'parsererror') {

Sink: jquery.form.js:781 setTimeout()
779
780 // clean up
781 setTimeout(function() {
782 if (!s.iframeTarget) {
783 $io.remove();
kindeditor.js, line 172 (Dynamic Code Evaluation: Code Injection)

@asheppard-gresham
Copy link

This sounds the same as #464

@kevindb
Copy link
Contributor

kevindb commented Jun 7, 2020

Would you please open a pull request to make the needed changes and update/create relevant tests?

@huntr-helper
Copy link

Bug Bounty

We have opened up a bounty for this issue on our bug bounty platform. Want to solve this vulnerability and get rewarded 💰? Go to https://huntr.dev/

We will submit a pull request directly to your repository with the fix as soon as possible. Want to learn more? Go to https://github.com/418sec/huntr 📚

Automatically generated by @huntr-helper...

@imade
Copy link

imade commented Jul 30, 2020

Seems same as #580

Official report: https://app.snyk.io/vuln/SNYK-JS-JQUERYFORM-574783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants