Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AND disable the consistent-this rule #553

Open
niftylettuce opened this issue Jul 12, 2018 · 3 comments
Open

Enable AND disable the consistent-this rule #553

niftylettuce opened this issue Jul 12, 2018 · 3 comments

Comments

@niftylettuce
Copy link

https://github.com/jquery-form/form/blob/master/src/jquery.form.js#L138

This line causes problems if we are concatenating with several other vendor pieces of code.

The only way to resolve this is to use dist/jquery.form.min.js, however it'd be great if we had a non-minified version in the dist folder as well 👍

@kevindb
Copy link
Contributor

kevindb commented Jul 12, 2018

Would you like to elaborate on what problems the comment is causing? I don't know what action would be appropriate if I don't know what it issue is.
Also, please feel free to open a PR with the changes. I am very open and responsive to pull requests.

@niftylettuce
Copy link
Author

basically if you have this rule but don't disable it - any other code concatenated afterwards will have to obey by the eslint rule, which causes conflict if other libraries in vendor bundled code don't respect consistent-this eslint rule (e.g. they use context or self or that instead of `this).

@kevindb
Copy link
Contributor

kevindb commented Mar 17, 2019

Please submit a pull request with changes to the grunt workflow to create a non-minified copy of the plugin in the dist folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants