-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of duplicates in the data #11
Comments
It seems the names are not correct; for example, for those 7 entries named "Forest", the actual names (from the Benjamin Moore web site) are:
Since all of them start with the word "Forest", my guess is some automation script for generating the database isn't parsing color names correctly and is only picking the first word. (Note: 1498 and CC-570 are the same paint and the duplication there would be correct.) I suspect the others are similar, as a quick search for the first result for "Spring" (263) is "Spring Morning". Also the first-word issue is not limited to duplicates. The database entry for the next color (264) is "Wandering", but on the Benjamin Moore site, the correct name is "Wandering Heart". Seems to be a bigger issue, where the duplicates are just a symptom. I'd guess it affects all of the Benjamin Moore colors, if not some large portion of the rest of the db as well. |
For example, look at https://github.com/jpederson/colornerd/blob/b91a655b638d94df598442a276b5c5dd13fa35d4/json/benjamin-moore.json and search for "Forest". You'll see 7 entries. If you search for "Spring", you'll find 26.
To see more duplicates that I found (and the script that found them), visit ryancwalsh/paint_color_gallery@95c5a48#diff-5b0b1e26f00ed029114efde1576a45c27cb3b4317dc7beb48a092146574df8fe
The text was updated successfully, but these errors were encountered: