Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code into a set of modules #8

Open
josephg opened this issue Mar 7, 2019 · 0 comments
Open

Refactor code into a set of modules #8

josephg opened this issue Mar 7, 2019 · 0 comments
Milestone

Comments

@josephg
Copy link
Owner

josephg commented Mar 7, 2019

Right now all the stores are in a big monolithic directory.

They should be pulled out into small, self contained (& tested) modules. I'm not sure if it makes sense to break them into a bunch of repos or not. Maybe something like:

  • Generic utilities pulled out separately. streamToIter, iterGuard
  • statecraft/core: All the stores with no dependancies. Mem kv & single, router, net, map, poll?
  • statecraft/*: Separate module for any of the "heavy" stores, which have more complex behaviour. Things like the foundationdb wrapper and OT stores.

This leaves a pretty heavy core. I need to make sure that specific parts can be targetted & pulled in to the browser in an isolated way that won't pull in half of the code.

The first step will be to just refactor this repo into a series of directories based on the module structure. After that I might move the code into a set of repos.

@josephg josephg added this to the stabilization milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant