Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

Support for PMD 7.x #1587

Open
1 task done
IlyasYOY opened this issue Jun 5, 2023 · 2 comments
Open
1 task done

Support for PMD 7.x #1587

IlyasYOY opened this issue Jun 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@IlyasYOY
Copy link

IlyasYOY commented Jun 5, 2023

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

I guess it'd be useful to add built in support for PMD 7.x: pmd/pmd#3898

The new version breaks compatibility.

Help

Yes

Implementation help

I have an example of PMD 7 usage. Null-ls may provide one additional PMD 7 source or put an advice/notice in documentation of the old one.

https://github.com/IlyasYOY/dotfiles/blob/master/config/nvim/lua/plugins/lsp.lua#L188

There are no new wrappers around run.sh required now.

PS. I also use FILENAME there to run scanning. It simply speeds things up a bit.

@IlyasYOY IlyasYOY added the enhancement New feature or request label Jun 5, 2023
@jose-elias-alvarez
Copy link
Owner

Since the new version breaks compatibility, do you think it's likely that users / projects will continue using the old version? If so, it might make sense to have a new source for the new version once it's released.

@IlyasYOY
Copy link
Author

IlyasYOY commented Jun 6, 2023

I personally think that users won't even notice changes in CLI API. Almost all project use Maven or Gradle plugins to handle PMD interactions. Users don't even download the CLI themselves.

So, I think null-ls may break compatibility, devs actively using null-ls will be able to update PMD binary easily. The changes are almost neglectable. Users will be able to go back to 6.x compatible option with a few lines of code (as I did 6.x -> 7.x).

But I'd wait for some more PMD to show up here with their feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants