Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define more than one extra path #395

Open
carlescufi opened this issue Dec 20, 2022 · 2 comments
Open

Ability to define more than one extra path #395

carlescufi opened this issue Dec 20, 2022 · 2 comments
Labels
enhancement User-facing feature enhancements

Comments

@carlescufi
Copy link
Contributor

As described in the title, the use case is being able to enable certain user-defined rules conditionally by adding to the extra-path that is already prepopulated in an existing .gitlint file.

@jorisroovers
Copy link
Owner

I can see how it would be useful to allow for multiple paths to be searched by specifying multiple --extra-path options. However "appending" to what's already specified in .gitlint conflicts with how gitlint works today wrt config precedence: CLI parameters override anything specified in .gitlint (by design).

I've seen this solved in other tools by adding a new "extend" parameter. For example, black has an --extend-exclude option which serves a similar purpose. We could do something similar by introducing an --extend-extra-path option.

@jorisroovers jorisroovers added the enhancement User-facing feature enhancements label Dec 21, 2022
@carlescufi
Copy link
Contributor Author

Sound like a good proposal, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User-facing feature enhancements
Projects
None yet
Development

No branches or pull requests

2 participants