Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor requests (the only dependency) out #5

Open
joohoi opened this issue Apr 8, 2018 · 3 comments
Open

Refactor requests (the only dependency) out #5

joohoi opened this issue Apr 8, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@joohoi
Copy link
Owner

joohoi commented Apr 8, 2018

While requests is awesome, there's a major benefit in not having any dependencies outside of the standard library. The refactored code should support both, Python 2 and 3. The refactoring will flow down to the published library https://github.com/joohoi/pyacmedns as well.

I would be grateful if someone is up for the task, but will handle it myself in the future if nobody is interested.

@joohoi joohoi added enhancement New feature or request help wanted Extra attention is needed labels Apr 8, 2018
@jvanasco
Copy link

since this is a certbot hook... certbot uses requests itself so you can expect that it's on the user's system/virtualenv already.

BUT

if you want this for pyacmedns, the python library acme-tiny accomplishes this and is easy to modify

@clayshieh
Copy link

I've written a simple request clone that handles basic GET/POST requests using standard libraries that should work for this. I will submit a PR for it soon.

@joohoi
Copy link
Owner Author

joohoi commented Jun 19, 2018

Thanks! Sounds awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants