-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamburger-box vertical align middle SCSS/CSS fix #117
Comments
Opened a PR! Let me know if the changes I made are exactly what you asked for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @jonsuh,
I want to make a small suggestion on the styling of hamburgers.
To be precise, the
.hamburger-box
hasdisplay: inline-block
, which is good. But it's missing:vertical-align: middle;
. I suggest adding this to the styling.Not that it is not possible to add this yourself additionally. But it saves everyone an extra line. I think you will make a lot of people happy with this change.
hamburgers/_sass/hamburgers/_base.scss
On line 51.
hamburgers/dist/hamburgers.css
On line 35
Thank you for your great work, this repo takes the websites we build to the next level!
Cheers!
The text was updated successfully, but these errors were encountered: