New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveConfigPath bugs #13

Open

cspotcode opened this issue Aug 2, 2019 · 0 comments

Labels

cspotcode commented Aug 2, 2019 •

edited

When calling parse('./directory'), the string is supposed to be interpreted as cwd.
https://github.com/jonschlinkert/parse-git-config/blob/master/index.js#L36

Yet that value is passed to resolveConfigPath('./directory') which treats it as the type instead of cwd.
https://github.com/jonschlinkert/parse-git-config/blob/master/index.js#L58
https://github.com/jonschlinkert/parse-git-config/blob/master/index.js#L89
https://github.com/jonschlinkert/parse-git-config/blob/master/index.js#L108

Additionally, this call to configPath passes the type but omits cwd. So when you call resolveConfigPath({cwd, type}) -- or pass the same options object to parse -- it will not do the right thing.
https://github.com/jonschlinkert/parse-git-config/blob/master/index.js#L110

The text was updated successfully, but these errors were encountered:

cspotcode changed the title ~~resolveConfigPath bug: API does not match parse()~~ resolveConfigPath bugs

jonschlinkert added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment