Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html-minifier to 4.0.0 #103

Open
oscarmarcelo opened this issue Sep 3, 2019 · 4 comments
Open

Update html-minifier to 4.0.0 #103

oscarmarcelo opened this issue Sep 3, 2019 · 4 comments

Comments

@oscarmarcelo
Copy link

Among other issues, the current dependency version has an issue with attributes without quotes when the value is a PHP expression, which appends trailing spaces, breaking attributes that expect numbers.

@rodrigograca31
Copy link

We should actually move to html-minifier-terser https://www.npmjs.com/package/html-minifier-terser

Because as stated here html-minifier uses:

uglify-es is no longer maintained and uglify-js does not support ES6+.

kangax/html-minifier#1040

@rodrigograca31
Copy link

rodrigograca31 commented Feb 6, 2020

ping @jonschlinkert
we should move to html-minifier-terser right........?

@jonschlinkert
Copy link
Owner

jonschlinkert commented Feb 6, 2020 via email

@rodrigograca31
Copy link

Then just let this project die? 😢

I still use it... and many other according to npm stats:
https://www.npmjs.com/package/gulp-htmlmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants