Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusive code extension hides spell checking #180

Open
jonpryor opened this issue Dec 7, 2022 · 2 comments
Open

Inclusive code extension hides spell checking #180

jonpryor opened this issue Dec 7, 2022 · 2 comments
Assignees
Labels
up-for-grabs Anyone can work on this. Assign yourself and give it a shot!

Comments

@jonpryor
Copy link

jonpryor commented Dec 7, 2022

It appears that only either spell checking or the inclusive code extension can be "active" at a given time.

Repro: write a comment that contains incorrectly spelled words, such as "quesiton".

Expected behavior: incorrectly spelled words are marked as such.

Current behavior: I'm making lots of typos. :-)

I suspect/fear that the inclusive comment extension will also need to contain a spell checker?

@jonathanpeppers jonathanpeppers added the up-for-grabs Anyone can work on this. Assign yourself and give it a shot! label Dec 7, 2022
@jonathanpeppers
Copy link
Owner

If someone can figure out, maybe because the extension used to be a spellchecker, it turns off built-in browser spellchecking?

@jonathanpeppers
Copy link
Owner

Might be related to:

("false" === e.getAttribute("spellcheck") && "false" === e.getAttribute("data-gramm")) || (e.setAttribute("spellcheck", "false"), e.setAttribute("data-gramm", "false"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up-for-grabs Anyone can work on this. Assign yourself and give it a shot!
Projects
None yet
Development

No branches or pull requests

3 participants