Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find usage of 'LanguageTool' in text and remove it #111

Open
jonathanpeppers opened this issue Apr 22, 2022 · 1 comment
Open

Find usage of 'LanguageTool' in text and remove it #111

jonathanpeppers opened this issue Apr 22, 2022 · 1 comment
Labels
up-for-grabs Anyone can work on this. Assign yourself and give it a shot!

Comments

@jonathanpeppers
Copy link
Owner

As seen in #110 there is a banner mentioning the original extension's name. We should just go through and remove instances of text like that, which would possible let us find a lot of code to remove. This would be things like banners & popups we don't actually want to show.
@jonathanpeppers jonathanpeppers added the up-for-grabs Anyone can work on this. Assign yourself and give it a shot! label Apr 22, 2022
@jonathanpeppers
Copy link
Owner Author

@ajhsu is going to look into this one.

@ajhsu ajhsu mentioned this issue Oct 5, 2022
Merged
jonathanpeppers added a commit that referenced this issue Nov 18, 2022
@ajhsu @jonathanpeppers
Project clean up - Part 1 (#157)
d232465 
This PR aims to address #111. But the code base is now tightly integrated with the original LanguageTool, so it's less likely to be done in one PR; Instead, we will clean it up piece by piece. This is the first part that cleans those easy targets from the code base.

* Remove unused l10n strings

Co-authored-by: AJ Hsu <[email protected]>
Co-authored-by: Jonathan Peppers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up-for-grabs Anyone can work on this. Assign yourself and give it a shot!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanpeppers @ajhsu