Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect mdePopoverOffsetX and mdePopoverArrowOffsetX calculation on inverted state #63

Open
viktor-naboka-gl opened this issue Sep 12, 2019 · 1 comment

Comments

@viktor-naboka-gl
Copy link

Bug:

In case if mdePopoverOffsetX was set popover positioning incorrect in the inverted state.

What is the expected behaviour?

In the inverted state (if space from expected side is not enough for view) offset must be calculated from inverted side.

What is the current behaviour?

Popover positioning in some case goes beyond the screen.
Offset works correct only for case when space on screen is enough for defined view position.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-popover-demo-q52fju

Other Comments

Similar issue also with mdePopoverArrowOffset.
Possible that Y offset also work incorrect please check it also.

@joejordanbrown
Copy link
Owner

@viktor-naboka-gl

Sorry I missed this issue.

I can confirm that does look like an issue with not calculating the arrow position dynamically. I will fix this when I have time unless someone else wants to add the dynamic arrow position feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants