Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing updates in CPreprocessor? #4

Open
felixalacampagne opened this issue Jun 19, 2020 · 1 comment
Open

Missing updates in CPreprocessor? #4

felixalacampagne opened this issue Jun 19, 2020 · 1 comment
Assignees

Comments

@felixalacampagne
Copy link

H, I've been trying to get the cdt 9.5.2 (for Eclispse Photon) version of the ProC plugin to work from the source code (I have no access to the compiled version in the development environment). Using the source as-is does not give any syntax highlighting and all proC statements are labelled as syntax errors. After some hour debugging I finally resorted to adding newLexer() methods to the org.eclipse.cdt.internal.core.parser.scanner.CPreprocessor class and using them to instantiate the Lexer in the CPreprocessor constructor - miracle or miracles I now have syntax highlighting and no more syntax errors in my proC source!
I've checked back with an old version of the buntatsu and indeed it does have newLexer methods in org.eclipse.cdt.internal.core.parser.scanner.CPreprocessor which are not present in the original eclipse code.

Was something missed when the updated eclipse source was transferred here? Am I missing something in how the ProC plugin is intended to work? I only have access to eclipse Photon at the moment so do not know whether the same problem exists in more recent versions.

Any chance that the changes to the eclipse CDT code could be submitted to eclipse so there is no longer a need to have a different version? From what I can see the changes are trivial, mostly to do with allowing sub-class access to the (pre)processor classes, plus the addition of the newLexer methods to allow the Lexer to be overriden?

Regards,,
Chris
BTW thanks for making the project available!!!

@jmramosr jmramosr self-assigned this Jul 18, 2020
@jmramosr
Copy link
Owner

Can you provide the code of the part I missed in the original plugin?

I'm sure I double checked the code of buntatsu prior to insert here.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants