-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non deterministic test #174
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The test 13 fails in the screenshot at #169 in Chrome at windows because it is testing against the top level container of the plugin instead of the parent of the steps (which I suppose is the actual canvas the test refers to). The top level container always have a
transition-duration
property in firefox with the value of0s
, so this test always passes in Firefox and always fails in chrome (see below)Chrome optimizes the "transition-duration" and puts the duration
inside "webkit-transition" property in the "style" attribute, so testing against the
style
property doesn't actually works across all browsers.To fix, test against the actual canvas element and instead of relying that the browser puts the
transition-duration
correctly inside the style attribute, test againt the actual css value (which tests for the property existence AND the correct value).web-stories@5e8a127
The text was updated successfully, but these errors were encountered: