Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urls.option_positions_url parameter #431

Open
slypete opened this issue Aug 25, 2023 · 0 comments · May be fixed by #432
Open

urls.option_positions_url parameter #431

slypete opened this issue Aug 25, 2023 · 0 comments · May be fixed by #432

Comments

@slypete
Copy link

slypete commented Aug 25, 2023

https://github.com/jmfernandes/robin_stocks/blob/6dc9dacae3e8882ffed3e3cf0eced02b147ef575/robin_stocks/robinhood/urls.py#L224C10-L224C10

The only parameter to this method, account_number, was intended to be optional, but it's mistakenly required. As a result, calls that don't pass the parameter result in a runtime error. For example:

robin_stocks/robin_stocks/robinhood/options.py

Line 79 in 6dc9dac

url = option_positions_url()

@slypete slypete linked a pull request Aug 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected option_positions_url slypete/robin_stocks
1 participant
@slypete