-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol jump to a line with half-width katakana jumps to incorrect position #253
Comments
If you have something like `let char: char = 'ア' // some extra text
to jump to` and try to symbol-jump to the text after the ア (this is
a half-width katakana), the cursor goes 1 position after the correct
destination.
Yeah, there are some (many) rough spots around unicode handling of
grapheme clusters with more than one codepoint. (In UTF-8, the
half-width katakana looks to be 0xE3 0x82 0xA2, which counts for more
graphemes than it actually is, thus causing cursor displacement.) There
was a similar issue causing the addition of a trailing newline to fail,
which was fixed in 10b0290 (PR #243 if I got that hash wrong). I don't
think I've got time to fix it right now, but I don't think it would be
awfully difficult if you want to take a look and put together a PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you have something like
let char: char = 'ア' // some extra text to jump to
and try to symbol-jump to the text after the ア (this is a half-width katakana), the cursor goes 1 position after the correct destination.
Amazing editor, by the way!
The text was updated successfully, but these errors were encountered: