Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Dockerfile labels #42

Open
alexcg1 opened this issue Jan 12, 2021 · 3 comments
Open

Dockerfile labels #42

alexcg1 opened this issue Jan 12, 2021 · 3 comments
Assignees

Comments

@alexcg1
Copy link
Member

alexcg1 commented Jan 12, 2021

To be able to push to Jina Hub a Dockerfile needs a whole bunch of labels. See wiki search Dockerfile as an example.

We should put these into the Dockerfile generated by cookiecutter

@JoanFM
Copy link
Member

JoanFM commented Jan 12, 2021

The labels I believe are extracted from the manifest.yml so I think this is not needed

@alexcg1
Copy link
Member Author

alexcg1 commented Jan 12, 2021

When I ran jina push ... it definitely wanted them in the Dockerfile. It threw error. I added it in Dockerfile, then it worked.

My manifest.yml doesn't even contain type and kind, so jina push must be skipping it

My manifest.yml:

manifest_version: 1
name: jina-wikipedia-sentences-50k
description: 'Example Jina Flows for searching 50,000 sentences from Wikipedia'
author: Jina AI Dev-Team ([email protected])
url: https://jina.ai
vendor: Jina AI Limited
documentation: https://github.com/alexcg1/jina-wikipedia-sentences
version: 0.0.1
license: apache-2.0
keywords: [NLP, wikipedia, text, distilbert]

@alexcg1
Copy link
Member Author

alexcg1 commented Jan 12, 2021

It states 50k bc that was my original plan. I haven't touched it for ages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants