Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a bug in create_vqx_hint.py? #5

Open
BierOne opened this issue Apr 29, 2020 · 1 comment
Open

Is there a bug in create_vqx_hint.py? #5

BierOne opened this issue Apr 29, 2020 · 1 comment

Comments

@BierOne
Copy link

BierOne commented Apr 29, 2020

Hi, jialing!
Recently, I am trying to introduce 'the most influential objects' into my model. However, when I check 'create_vqx_hint.py', I don't understand the code at lines 187-189.

if cosine_similarity(exp_emb[attr_token:attr_token+1], atts[j:j+1]) > 0.3 :
        if hint_score_attr[j] <= cosine_similarity(exp_emb[attr_token:attr_token+1], atts[j:j+1]):
                hint_score[j] = cosine_similarity(exp_emb[attr_token:attr_token+1], atts[j:j+1])

I also found that you don't use 'hint_score_attr' anymore, but this code would change 'hint_score[j]' that has been assigned at line 179. Thus, is it should be more reasonable that using 'hint_score_attr[j]' to replace 'hint_score[j]' at line 189. like this:

if cosine_similarity(exp_emb[attr_token:attr_token+1], atts[j:j+1]) > 0.3 :
        if hint_score_attr[j] <= cosine_similarity(exp_emb[attr_token:attr_token+1], atts[j:j+1]):
                hint_score_attr[j] = cosine_similarity(exp_emb[attr_token:attr_token+1], atts[j:j+1])
@alice-cool
Copy link

学者您有train36百度云盘的下载链接吗?国内google drive 显示下载配额不够,不知道怎么能下载文件,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants