Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google Cloud Run Deploy Button #398

Open
1 task done
SudharakaP opened this issue Dec 6, 2019 · 5 comments · May be fixed by #399
Open
1 task done

Add Google Cloud Run Deploy Button #398

SudharakaP opened this issue Dec 6, 2019 · 5 comments · May be fixed by #399

Comments

@SudharakaP
Copy link
Member

Overview of the issue

I tried to do this on #395 but ran into some problems both with the Google Cloud Run Button side which we've discussed at GoogleCloudPlatform/cloud-run-button#112 and on the JHipster Registry side which @jkutner is woking on at jhipster/jhipster-registry-buildpack#3. After these issues are solved I'll re-add this button and test it out. 😄

Related issues:

Motivation for or Use Case

Quickly deploy the registry to cloud run just as we do on Heroku.

Related issues

#397

  • Checking this box is mandatory (this is just to show you read everything)
@SudharakaP SudharakaP mentioned this issue Dec 6, 2019
Closed
@mraible
Copy link
Contributor

mraible commented Dec 6, 2019

If you run into issues, you might ask @jamesward for help.

@jkutner
Copy link
Contributor

jkutner commented Dec 6, 2019

I've fixed and merged jhipster/jhipster-registry-buildpack#3 so the app.json in this repo should be testable now.

@SudharakaP SudharakaP linked a pull request Dec 7, 2019 that will close this issue
Draft
4 tasks
@SudharakaP
Copy link
Member Author

Just for the information, I think the buildpacks field still needs to be supported as per GoogleCloudPlatform/cloud-run-button#3 in order to test this. Otherwise we get,

Welcome to Cloud Shell! Type "help" to get started.
To set your Cloud Platform project in this session use “gcloud config set project [PROJECT_ID]”
sudharakapalamakumbura@cloudshell:~$ cloudshell_open --repo_url "https://github.com/SudharakaP/jhipster-registry.git" --page "shell" --git_branch "add-cloud-run-button"
[ ✓ ] Cloned git repository https://github.com/SudharakaP/jhipster-registry.git.
Error: error attempting to read the app.json from the cloned repository: failed to parse app.json file: failed to parse app.json: json: unknown field "buildpacks"
sudharakapalamakumbura@cloudshell:~$

@jamesward
Copy link

I'll investigate how we can support this.

@SudharakaP
Copy link
Member Author

SudharakaP commented Mar 24, 2020 •
edited

@jamesward : Thanks a bunch. Feel free to let know if there's anything we can do on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Google Cloud Run Button SudharakaP/jhipster-registry
4 participants
@jkutner @mraible @jamesward @SudharakaP