Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: vue-core module #7587

Open
pascalgrimaud opened this issue Sep 26, 2023 · 3 comments · May be fixed by #7629
Open

Refactoring: vue-core module #7587

pascalgrimaud opened this issue Sep 26, 2023 · 3 comments · May be fixed by #7629

Comments

@pascalgrimaud
Copy link
Member

I think we need to rework on the vue-core module and to split between smaller modules.

I think the vue-core module should add:

  • Vue.js with Vite
  • axios
  • vue-router (can be discussed)
  • all important tools like eslint, typescript, vitest + config, etc

It should not add the home page

Then, the home page should be splitted into 2 modules:

  • vue-home-domain, which depends on vue-core
  • for the primary part, which depends on vue-home-domain:
    • vue-home-primary-native, with default App.html, AppVue.vue etc
    • vue-home-primary-bootstrap
    • vue-home-primary-tailwind (for example)
    • etc

Pinia should be in another dedicated module.

Don't hesitate to comment this, if you have better idea.

@abdelfetah18
Copy link
Contributor

I want to work on this,
but I need more details about vue-home-domain.
Could you please explain its purpose?

Regarding vue-router, I suggest making it a separate module, similar to vue-pinia.

@pascalgrimaud
Copy link
Member Author

I need to think more, but for now, the vue-home-domain would be nearly empty, as there is no domain. Or maybe simply a Home.ts which would contains the welcome message.

@pascalgrimaud
Copy link
Member Author

About vue-router and vue-pinia, yes, it should be in separated modules

@abdelfetah18 abdelfetah18 linked a pull request Oct 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@pascalgrimaud @abdelfetah18 and others