Maven: removeDependency doesn't remove property for version

[murdos]

jhipster-lite/src/main/java/tech/jhipster/lite/generator/server/springboot/core/domain/SpringBootCoreModuleFactory.java

Line 57 in 4f375e7

.removeDependency(dependencyId(MOCKITO_GROUP, "mockito-junit-jupiter"))

does not remove <mockito.version>5.4.0</mockito.version> in pom.xml

See https://github.com/jhipster/jhipster-lite-sample-app/blob/0df81108ece4f8838e4236753e006000775b2fb5/pom.xml#L24C6-L24C21

TO-DO: Implement safe removal of versions

• When removing the dependency manager
• When removing a direct dependency
• Profile: When removing the dependency manager
• Profile: When removing a direct dependency

[pascalgrimaud]

I wonder if the method removeDependency should remove the version too, or should we add a new method removeVersion?
I'd prefer the 2nd solution, with a new method

[murdos]

The

I wonder if the method removeDependency should remove the version too, or should we add a new method removeVersion? I'd prefer the 2nd solution, with a new method

The property is added automatically when a dependency is added. If possible it would be nice the automatically remove the property if it not used anymore. But I will think more about it and see how it would translate it the gradle side too.

[DamnClin]

Not that simple since a version property can be used by multiple dependencies