Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAuthenticated is not used? #8

Open
webmobiles opened this issue Sep 11, 2017 · 3 comments
Open

isAuthenticated is not used? #8

webmobiles opened this issue Sep 11, 2017 · 3 comments

Comments

@webmobiles
Copy link

I look for the code when isAuthenticated (connectors.js) is called but i've not found.

If I run on graphiql the query to list user and don't send a token:

query {
  users  {
        id
    email
    lastName
    firstName
        
      }
 

have no errors, so authentication is not working, am I right?

@jferrettiboke
Copy link
Owner

Hi @webmobiles.

You are right. isAuthenticated() is not being used on server-side at the moment. You can implement it wherever you want in order to protect some data from server.

PRs are accepted in case you would like to send some improvements. 😄

@webmobiles
Copy link
Author

nice, you did a good job, how i can open a PR?

@jferrettiboke
Copy link
Owner

Thanks, @webmobiles. I will try to improve it more in the future.

Here you are! https://help.github.com/articles/creating-a-pull-request/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants