Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update deprecated subdependencies: [email protected], [email protected] in @jest/types #15027

Closed
avetalia opened this issue Apr 14, 2024 · 3 comments

Comments

@avetalia
Copy link

🚀 Feature Proposal

Update deprecated dependencies in @jest/types:
[email protected], [email protected]

https://www.npmjs.com/package/abab
Author message:
"Use your platform's native atob() and btoa() methods instead"

https://www.npmjs.com/package/domexception
Author message:
Use your platform's native DOMException instead

Motivation

Warn message:
2 deprecated subdependencies found: [email protected], [email protected]

Example

No response

Pitch

n/a

@G-Rath
Copy link
Contributor

G-Rath commented Apr 17, 2024

In v29.7.0 these are bring brought in by jest-environment-jsdom through jsdom:

└─┬ [email protected]
  └─┬ [email protected]
    ├── [email protected]
    ├─┬ [email protected]
    │ └── [email protected] deduped
    └── [email protected]

and I'm not seeing any direct references to those packages in the Jest codebase so I'm pretty sure they're being brought in by nested dependencies which means this isn't really something directly addressable by Jest.

Note that most likely reason that packages have not moved off such packages is because of Node version support - both atob and btoa were introduced in Node v16, and DOMException was introduced in Node v17; while v16 is no longer in-life it's still supported by a lot of packages.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label May 17, 2024
@SimenB
Copy link
Member

SimenB commented May 19, 2024

Yeah, these come from JSDOM. Jest 29 ships with v20 - Jest 30 will ship with v22, and if you want to use latest (v24 at the time of writing) you'll need to do something like #14954 (comment)

@SimenB SimenB closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants