New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing a gpg signed commit message via a Editor crashes #3490
Comments
What happens here is that the Which means that there are two potential solutions to this bug:
The first of these is tricky and requires more work (see here; I'm not really sure I understand that comment though...). The second is much easier, all it takes is a call to |
- **PR Description** Simplify and canonicalize error handling across the code base. Previously it was important to make sure that errors don't bubble up into gocui, because it would panic there; so we had to show errors in error panels in the right places (in controller code, usually). This is error-prone because it's easy to forget (see #3490 for an example); also, it's not always obvious where in the call chain the error panel needs to be shown. Most of the time it's in controller code, but we had plenty of calls to `Error()` in helpers, and I remember that I found this very confusing when I was new to the code base. Change this so that you can simply return errors everywhere. The functions to show an error message manually have been removed for clarity. I tried to structure the commits so that you can review them one by one. Closes #3491.
Describe the bug
A clear and concise description of what the bug is.
When editing a GPG signed commit, and doing C-o e to Open in Editor lazygit crash
To Reproduce
Steps to reproduce the behavior:
Expected behavior
not crashing
Screenshots
If applicable, add screenshots to help explain your problem.
Version info:
commit=, build date=, build source=homebrew, version=0.41.0, os=darwin, arch=arm64, git version=2.44.0
Additional context
Add any other context about the problem here.
Note: please try updating to the latest version or manually building the latest
master
to see if the issue still occurs.The text was updated successfully, but these errors were encountered: