New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pasting (cherry picking) commits onto branch from branches view #3275
Comments
Hi @jesseduffield , I would like to give it a try. Would you please assign me? |
Sure thing @nhAnik, let me know if you need any pointers. For starters you'll want to add the keybinding to |
Thanks! |
I wonder if the proposed UX is the best one for this feature. Personally I would find it somewhat unexpected that a branch is checked out automatically when I invoke this command. With the new 2.44 version of git we could consider a different approach:
The downside is that we'd have to make a version-check and disable the command for git versions older than 2.44; also, the replay command is marked as experimental in the documentation, so I'm not sure we already want to rely on it. Any thoughts @jesseduffield? |
I'm in favour for a feature for git replay that's marked as experimental in tandem with the underlying git feature. |
OK cool. @nhAnik I haven't looked at the code of #3288 at all to tell how much of it was done in vain. Sorry for not mentioning this earlier! BTW, one downside of the |
Is your feature request related to a problem? Please describe.
Currently, in order to cherry-pick commits, you need to:
In github desktop you instead select select the commits and right click to cherry pick, then in a popup you specify the destination branch. That branch is then checked out (with any working tree changes stashed if required) and the commits are cherry picked. You then remain on the destination branch.
Describe the solution you'd like
Given that we're not using the 'V' keybinding for anything else in the commits view, I think we should support pressing 'V' directly on the branch. This will:
We should also support this if you're in the sub-commits view, viewing the commits of a local branch.
This slightly reduces the amount of work required in cherry picking commits from one branch to another.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
The text was updated successfully, but these errors were encountered: