-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update method types overlay 2 #367
Milestone
Comments
Hey, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for the quick release of the previous fix! However, the update method types overlay is still not working for me, I found another possible issue:
The return type of update method contains
FirstDefined<[O.Pick<Item, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]>
and the response type I get for Attributes is{} | undefined
.I think it should be
FirstDefined<[O.Pick<EntityItemOverlay, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]>
.What's more, the response I get is
FirstDefined<[O.Pick<EntityItemOverlay, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]> | {} | undefined
. I think there is something more to resolve in order to get rid of that{}
The text was updated successfully, but these errors were encountered: