Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/use installation configuration ServerUrl instead of action ServerUrl #139

Open
TheMagician1 opened this issue Mar 9, 2023 · 0 comments

Comments

@TheMagician1
Copy link

What feature do you want to see added?

We have Gerrit, Jenkins and Sonarqube running behind a reverse proxy for public/external access, but internally they can reach each other on a different DNS. So our users use the external DNS to reach Sonarqube, but Jenkins is using the internal DNS.
This way we can add additional security to access sonarqube.

For the sonar scan stage this works, because it uses the internal DNS to get the configuration and post the results.
Now we want to decorate our changes in Gerrit using this plugin, but it uses the public DNS that is set in the action to connect to Sonarqube. We would like it to use the same DNS that is configured in the installation configuration of SonarQube.

In the tryCreate function of the PullRequestAnalysisTask it is now getting the serverUrl from the action, but also the SonarInstallation is available to fetch the credentials. Could it be changed to also use the serverUrl from the SonarInstallation object?

Thank you for consideration!

Upstream changes

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant