Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently fail if the build is not triggered from Gerrit #125

Open
felipecrs opened this issue Jul 14, 2022 · 0 comments
Open

Silently fail if the build is not triggered from Gerrit #125

felipecrs opened this issue Jul 14, 2022 · 0 comments

Comments

@felipecrs
Copy link

What feature do you want to see added?

On my projects where I call sonarToGerrit, sometimes I need to manually trigger a build (for whatever reason).

When I do that, Gerrit Trigger or the Gerrit Code Review Plugin will not inject their environment variables for sonarToGerrit to use and therefore the build will fail.

It would be nice if sonarToGerrit could silently fail if the build is NOT triggered by Gerrit and is missing those environment variables, just like the steps provided by the Gerrit Code Review plugin also does (like gerritReview).

By using the catchError step, you could even mark the step as failed (red), while yet keeping the original status of the stage or the pipeline (this is also what the Gerrit steps does).

Upstream changes

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant