-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the input value allowed_spot_instance_types to allowed_instance_types #307
Comments
override_instance_types is used to specify spot instance types in the eks module we use internally. See https://github.com/terraform-aws-modules/terraform-aws-eks/blob/926af35595d1e8747d6a41f8de445316400fbbc8/workers_launch_template.tf#L163 Also an example can be found here: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/a26c9fd0c9c880d5b99c438ad620e91dda957e10/docs/spot-instances.md#using-launch-templates |
It is also used for regular instance types, not only spot? |
It should not be I think, if it is, it could be a bug in the eks module we use. |
Summary
the value for
allowed_spot_instance_types
is used for regular instance types and really has nothing to do with spot instances. Should be renamed toallowed_instance_types
Also, in the documentation:
But in the code at
terraform-aws-eks-jx/modules/cluster/main.tf
Line 81 in e342b9d
The text was updated successfully, but these errors were encountered: