New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to artifact registry for GKE #8656
Closed
4 of 6 tasks
Labels
area/gke
kind/task
Activity or chore which needs to be done
severity/critical
it should be addressed as soon as possible
Comments
msvticket
added
area/gke
kind/task
Activity or chore which needs to be done
severity/critical
it should be addressed as soon as possible
labels
Apr 8, 2024
Hi @msvticket i made a PR jenkins-x/terraform-google-jx#235 where i added the GCP Artifact Registry for Docker image, don't need authentication, I used service account (default to allow nodes to download images), and tekton to upload images. |
I made a PR in jx3-terraform-gke to reflect the changes on terraform-google-jx |
msvticket
pushed a commit
to sergiogiuffrida/terraform-google-jx
that referenced
this issue
Apr 25, 2024
part of fix for jenkins-x/jx#8656
msvticket
pushed a commit
to sergiogiuffrida/terraform-google-jx
that referenced
this issue
Apr 25, 2024
also removed section regarding Jenkins X 2, which hans't been supported in along time updated the table of content part of fix for jenkins-x/jx#8656
msvticket
added a commit
to jx3-gitops-repositories/jx3-gke-gsm
that referenced
this issue
Apr 26, 2024
from version 1.12.0 of https://github.com/jenkins-x/terraform-google-jx registry is by default set by the terraform module, so it would be overwritten anyway. Part of fix for jenkins-x/jx#8656
msvticket
pushed a commit
to jx3-gitops-repositories/jx3-terraform-gke
that referenced
this issue
Apr 29, 2024
Part of fix for jenkins-x/jx#8656
msvticket
added a commit
to jenkins-x/jx-docs
that referenced
this issue
May 6, 2024
Fixes jenkins-x/jx#8656 Signed-off-by: Mårten Svantesson <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/gke
kind/task
Activity or chore which needs to be done
severity/critical
it should be addressed as soon as possible
Currently Jenkins X on GKE is by default using Container Registry for images. But Google will discontinue container registry and recommends migration to Artifact Registry. https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
So what is needed is (at least):
terraform state rm
to prevent cloud registry from being disabled while migrating. Also https://jenkins-x.io/v3/admin/platforms/google/svc_acct/ needs to be updated to include the role roles/artifactregistry.admin.The above assumes the same repository is used for all images. If we instead want to follow the convention of having the name of the git repository owner as repository (or in Jenkins X parlance "docker registry org") support in jx-registry for checking the existence of and if needed create the repository is needed. But I don't think that is worth the effort.
The text was updated successfully, but these errors were encountered: