Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: make title bar black #12

Open
JakobFelixJulius opened this issue May 25, 2019 · 1 comment
Open

Feature Request: make title bar black #12

JakobFelixJulius opened this issue May 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@JakobFelixJulius
Copy link

Hello,
First: Cool project! One small change that would improve the visuals imo: the titlebar right now is grey. If you scroll Netflix, the Netflix-title-bar (with search, browse, etc.) is always black, so wouldn't it make sense to make the app-title-bar also black to merge it with the Netflix-title-bar and have a nice and consistent look (and an "vanishing title bar")?
Greetings

@jellybeansoup
Copy link
Owner

Thanks! (…and sorry that it's taken so long to respond to your request!)

The overall look of the titlebar is/has been a conscious choice on my part, so I'm not really looking to change how it appears on a wholesale basis. I wouldn't necessarily say no to a preference similar to the Keep in Front/Snap to Corners options, though. Perhaps "Use Opaque Titlebar"? I'll leave the issue open to remind me to tackle this when I next get a minute.

OOC: I should probably consider actually setting up a preferences pane for this stuff going forward 🤔

With that in mind, the most recent release has some tweaks to the titlebar that would possibly make this easier to accomplish. Right now the alpha of the colour overlay I've added is at 0.4, but by setting it to 1.0, you should get roughly the effect you're expecting (Netflix's headers aren't quite pure black, though… they're actually #090909):

let overlay = CALayer()
overlay.frame = layer?.bounds ?? .zero
overlay.backgroundColor = NSColor(deviceWhite: 0, alpha: 0.4).cgColor
overlay.autoresizingMask = [.layerWidthSizable, .layerHeightSizable]
layer?.addSublayer(overlay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants