Factor Clibsodium into its own sub-package.
#234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnross
commented
Dec 21, 2020
| @@ -32,5 +32,5 @@ Pod::Spec.new do |s| | |||
|
|
|||
| s.requires_arc = true | |||
|
|
|||
| s.vendored_frameworks = "Clibsodium.xcframework" | |||
| s.vendored_frameworks = "Clibsodium/Clibsodium.xcframework" | |||
There was a problem hiding this comment.
I'm not sure if this change to the podspec works correctly with the directory structure changes.
|
This approaches works fine locally, but throws some weird errors about versioning when I try to add the dependency pointed to the remote git URL. |
|
Closing. This is not what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change appears to fix #233, which may occur due to Xcode incorrect parallelizing the build of target dependencies in a single package. Putting Clibsodium in its own package appears make this dependency more clear.
I would mark this PR as a draft if I could. In particular I have not tested whether my change to the podspec works correctly. That part of the diff is just a guess.