Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybind issue #50

Open
XMU-qcj opened this issue Oct 27, 2022 · 9 comments · May be fixed by #56
Open

Pybind issue #50

XMU-qcj opened this issue Oct 27, 2022 · 9 comments · May be fixed by #56

Comments

@XMU-qcj
Copy link

XMU-qcj commented Oct 27, 2022

Thank you very much for your work!
I didn't find any bindings to python in the compile command you provided, am I missing something?

@pdell-kitware
Copy link
Collaborator

Hi,

The python bindings were available in a previous version,
And we have yet to reimplement them,

To be honest, it wasn't very high our long list of priorities, as we didn't expect them to be much used.

But if you are interested, I can start working on them again (this should be available next week)

Let me know,

Cheers

@dandric
Copy link

dandric commented Nov 10, 2022

I'm interested to have 1/ python bindings for the current version and 2/ it would help with related work in pyLiDAR-SLAM too. Please let me know what are the next steps, and the time frame. If that need time, some direction how to do it on current versions would help.

@pchundi
Copy link

pchundi commented Nov 15, 2022

+1 for fixing the Python bindings in the latest version

@pdell-kitware
Copy link
Collaborator

Hi,

Ok then !
So I'll start working on it by the end of the week, it should be ready at the latest early next week.

In the mean-time, to do the binding I used pybind11, the previous version is accessible at: https://github.com/jedeschaud/ct_icp/tree/old_master/src/binding

@pchundi
Copy link

pchundi commented Nov 28, 2022

@pdell-kitware: thank you for prioritizing this issue! Anyway I can help?

@pdell-kitware
Copy link
Collaborator

Started working on it, see PR #56

I'll notify this issue when I am done

@pdell-kitware
Copy link
Collaborator

pdell-kitware commented Dec 5, 2022

Hi, So a first version of the binding is completed for CT-ICP,

See the branch python_bindings, there are some explanations in the Readme.md,

I'll try to integrate update the binding to pyLiDAR-SLAM in the week (I need to update the binding which have different function names, and methods)

@pdell-kitware pdell-kitware linked a pull request Dec 5, 2022 that will close this issue
11 tasks
@JUN1026
Copy link

JUN1026 commented May 11, 2023

First of all thanks a lot for the author's work, I recently tried ct-icp and pyLiDAR and tried to call ct-icp in pyLiDAR.

I spent a lot of time trying pybind but failed, and finally found out that the project's bindings folder was updated two years ago, so many functions were having problems. In the previous comment, pdell-kitware said that the bindings file will be updated, I would like to know where the last updated file is available? How does the final combination with pyLiDAR work?

I would be grateful if you could answer my questions.

@friendship1
Copy link

First of all thanks a lot for the author's work, I recently tried ct-icp and pyLiDAR and tried to call ct-icp in pyLiDAR.

I spent a lot of time trying pybind but failed, and finally found out that the project's bindings folder was updated two years ago, so many functions were having problems. In the previous comment, pdell-kitware said that the bindings file will be updated, I would like to know where the last updated file is available? How does the final combination with pyLiDAR work?

I would be grateful if you could answer my questions.

same here,
Which is the "latest version" and which is the "first version"?
I couldn't find any branches or tags related to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants