New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeferredFutureTask and global CallbackExceptionHandler #138
Comments
Good thing I renamed the global exception handler to CallbackExceptionHandler. We can have a CancellationExceptionHandler? |
Then this block may not be needed https://github.com/jdeferred/jdeferred/blob/2.x/subprojects/jdeferred-core/src/main/java/org/jdeferred/DeferredFutureTask.java#L180-L183 |
trying to lookup the code in the new package, but i don't think this is it: https://github.com/jdeferred/jdeferred/blob/2.x/subprojects/jdeferred-core/src/main/java/org/jdeferred2/DeferredFutureTask.java#L180-L183 |
ah, i think it's referring to https://github.com/jdeferred/jdeferred/blob/2.x/subprojects/jdeferred-core/src/main/java/org/jdeferred2/DeferredFutureTask.java#L188-L191 this might never happen since exceptions are handled by the global exception handler already in each of the calls, right? If that's the case, would you prefer to have a new |
The thrown I'd say let's keep it as is for the time being. |
DeferredFutureTask
has a pair of TODOs stating the need of re-routing an exception throughCallbackExceptionHandler
.. Problem is, the exception may occur duringresolve
orcleanup
thus they do not occur under any of the 4 types of callbacks currently handled by CEH.The text was updated successfully, but these errors were encountered: