Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

Issue with exifs on samsung devices #117

Open
iovorobiev opened this issue May 14, 2015 · 7 comments
Open

Issue with exifs on samsung devices #117

iovorobiev opened this issue May 14, 2015 · 7 comments
Labels

Comments

@iovorobiev
Copy link

There are some issues with crop on samsung devices when doing non-square crop. It caused by rotating matrix by -exif_rotate value and than adding exif. Suppose I want to crop picture to get 16:9 rectangle and then set it to ImageView by using standard setImageUri() method.
cropping

then I getting this

cropped

If I will use a library which reads exif and applies rotating then I getting this

with_glide_2

So, the main issue, is when we apply exif to cropped picture, we rotate the whole bitmap and change it's dimensions from 16:9 to 9:16. Also, if we not apply exif parameters when setting picture to image view the picture will be rotated by minus exif rotation angle and stretched to given dimensions. I've fixed this this issue in mine pull request #116. If you have another solution, please fix it.

@jdamcd jdamcd added the bug label May 17, 2015
@jdamcd
Copy link
Owner

jdamcd commented May 21, 2015

Are you using the same Uri for input & output?

I'm keen to fix this, but have trouble reproducing the issue. Are you using a specific camera app? Or maybe you could provide an image with problem EXIF data.

@sridharkrishna
Copy link

I working on camera app ... And I'm using same uri for storing images.
..but what u mean by exifs ... You asked about android interface .??.
On May 21, 2015 11:54 PM, "Jamie McDonald" [email protected] wrote:

Are you using the same Uri for input & output?

I'm keen to fix this, but have trouble reproducing the issue. Are you
using a specific camera app? Or maybe you could provide an image with
problem EXIF data.


Reply to this email directly or view it on GitHub
#117 (comment)
.

@iovorobiev
Copy link
Author

@jdamcd yes, I am using the same uri for input and output. I use a standard camera app on Samsung Galaxy Note 2. For me this issue reproduces only on samsung devices.

@kungfucop
Copy link

we also see the issue on samsung device, is that possible to make a fast fix for that? Thanks!!

@dkozel
Copy link

dkozel commented Jun 1, 2015

I can reliably reproduce this in the 1.0.0 release on a Samsung Galaxy S4 with Android 4.4.2.

@GameDevLlama
Copy link

Today I found out that it's possibly related not only to exif itself but also the Uri handling. When opening an image via the "last" section of my system gallery app I could reproduce the bug with the wrong rotation, since the Uri was shortened by the gallery app somehow. After resolving the shortened Uri to the full Uri of the file it worked correctly again. I fixed this in my forked repo and will probably make a pull request during the next couple of days

@thameemulansari
Copy link

@TheWhiteLlama , Do you have an fix for the issues mentioned through out this thread ? Please provide your branch and code changes . will be helpful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants