You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preface: I'm too unfamiliar with github (and especially pull requests) to submit a fix directly. But there is a (possibly partial, not sure if this extends to anywhere else) suggestion below.
Unlike what is suggested here, buttons for my cover entities do not automatically get the same color as --rgb-cover-active-color:
-`--pbs-button-rgb-state-color` – this is set automatically to reference an `--rgb-state-*-color` variable.
What version of Paper Buttons Row has the issue?
2.1.3
What version of Home Assistant are you running?
2023.10.1
What version of the Frontend are you running?
20231005.0 - latest
Additional information
I believe the issue is that the check here is for stateObj.state === STATE_ON (so it only works with entities that have an "on" active state) instead of STATES_ON.has(stateObj.state) (which includes "on", but also "open" and "unlocked").
I made that change locally in "paper-buttons-row.js" (well:Dt.has(r.state); in both instances) and that appears to have fixed it for me.
The text was updated successfully, but these errors were encountered:
arvidc
changed the title
--rgb-*-*-color not retrieved automatically for cover-entity (presumably just any (binary) entity that has a different state than on/off)
--rgb-*-*-color not retrieved automatically for cover-entity (presumably just any (binary) entity that has no 'on'-state)
Oct 12, 2023
The problem
Preface: I'm too unfamiliar with github (and especially pull requests) to submit a fix directly. But there is a (possibly partial, not sure if this extends to anywhere else) suggestion below.
Unlike what is suggested here, buttons for my cover entities do not automatically get the same color as
--rgb-cover-active-color
:lovelace-paper-buttons-row/README.md
Line 158 in 85524ff
What version of Paper Buttons Row has the issue?
2.1.3
What version of Home Assistant are you running?
2023.10.1
What version of the Frontend are you running?
20231005.0 - latest
Additional information
I believe the issue is that the check here is for
stateObj.state === STATE_ON
(so it only works with entities that have an "on" active state) instead ofSTATES_ON.has(stateObj.state)
(which includes "on", but also "open" and "unlocked").lovelace-paper-buttons-row/src/main.ts
Lines 422 to 424 in 85524ff
I made that change locally in "paper-buttons-row.js" (well:
Dt.has(r.state)
; in both instances) and that appears to have fixed it for me.The text was updated successfully, but these errors were encountered: