Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support xr.Dataset input #85

Open
jbusecke opened this issue Mar 22, 2022 · 0 comments
Open

Fully support xr.Dataset input #85

jbusecke opened this issue Mar 22, 2022 · 0 comments

Comments

@jbusecke
Copy link
Owner

Quick reminder here:

I guess an additional test (or a parametrization for the existing ones) would have been ideal. In case you are up for adding that, I would wait, but not a big deal in my view.

I agree, but that would take considerably longer and I'm going to take some time off starting today. I thought it was better to get the bug fix out as soon as possible.

I can help you out in the future if you want to add tests for datasets and make that aspect of xmovies fully supported.

Originally posted by @tomchor in #83 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant