Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighten requirements? #71

Open
zmoon opened this issue Dec 8, 2021 · 3 comments · May be fixed by #73
Open

Lighten requirements? #71

zmoon opened this issue Dec 8, 2021 · 3 comments · May be fixed by #73

Comments

@zmoon
Copy link
Contributor

zmoon commented Dec 8, 2021 •
edited

dask and cartopy could be optional requirements, with exceptions raised if code that needs them is called without them installed, as they are not needed for the core functionality. Just a thought.
@jbusecke
Copy link
Owner

jbusecke commented Dec 8, 2021

This seems very reasonable indeed. I currently do not have the bandwidth to implement this though. Do you think you would have time to submit a PR? No pressure at all, though. Raising this issue is already very helpful.

@zmoon
Copy link
Contributor Author

zmoon commented Dec 10, 2021

Yes I will give it a try after #67

@jbusecke
Copy link
Owner

Excellent. I really appreciate your efforts here @zmoon!

This was referenced Dec 16, 2021
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dependencies zmoon/xmovie
2 participants
@jbusecke @zmoon