-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCM send_message return type is not compatible with previous output #722
Comments
My point is that previously it was possible to handle the output of different Now the code should be reworked to hande the My question is: is this project willing to keep a common API for |
The implementation with firebase SDK has changed the output of the
send_message
methodBefore it was a
dict
django-push-notifications/push_notifications/gcm.py
Lines 202 to 204 in 7d28052
Now it is a
BatchResponse
django-push-notifications/push_notifications/gcm.py
Lines 188 to 190 in 0f79181
This means that any code which relies on the output to be a dict now need to work-around the new type.
This is a breaking change which should have been highlighted or avoided.
The text was updated successfully, but these errors were encountered: