-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch over from GCM to FCM #618
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My understanding that nobody uses GCM anymore, so perhaps it is time for the upgrade?
My suggestion would be to rename GCM model to FCM model (breaking change) and add
platform
choices/enum to it, like I've done in the #615I agree perhaps there is no reason to keep the GCM model anymore and
message_type
but it will be a (small) breaking change.What are your thoughts?
Rename GCM to FCM?
Keep GCM as a proxy model for backward compatibility? (seems like unnecessary work)
platform choices:
a) android, ios, web - full text in the database consistent with the rest of the library
b) a, i, w - save space
c) 0, 1, 2 - save space, easy indexing, sorting
d) new django enums
The text was updated successfully, but these errors were encountered: