Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on console when using react v16.4 #94

Open
rishichawda opened this issue Oct 31, 2018 · 4 comments
Open

Warning on console when using react v16.4 #94

rishichawda opened this issue Oct 31, 2018 · 4 comments

Comments

@rishichawda
Copy link

When used with react v16.4, it throws an error in dev console which was introduced after v16.3 in support of removing the componentWillMount, componentWillReceiveProps, and componentWillUpdate lifecycle methods.

Since themr.js uses the componentWillRecieveProps lifecycle method, when used in a project with react v16.4, it throws a console warning. Moreover, this method will be deprecated in future releases of React ( v17.0 )

More about this here.

@rishichawda rishichawda changed the title Warning on console when using react v16.4 and above Warning on console when using react v16.4 Oct 31, 2018
@ovaldi
Copy link

ovaldi commented Oct 31, 2018

@rishichawda this repo is no longer maintained for 1+ year, now we use https://github.com/FriendsOfReactJS/react-css-themr

Please upgrade to the new version.

@rishichawda
Copy link
Author

rishichawda commented Oct 31, 2018

@ovaldi The same problem persists with the https://github.com/FriendsOfReactJS/react-css-themr fork. Should I raise the PR there?

Update : I've raised a pull request on the maintained fork. Hope that gets merged soon. Thanks @ovaldi for letting me know. Link to PR

@ovaldi
Copy link

ovaldi commented Nov 1, 2018

@rishichawda Cool!

@markusguenther
Copy link

Problem has been solved in the fork ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants