Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismissable bug #30

Open
ValiDrv opened this issue Sep 29, 2018 · 0 comments
Open

dismissable bug #30

ValiDrv opened this issue Sep 29, 2018 · 0 comments

Comments

@ValiDrv
Copy link

ValiDrv commented Sep 29, 2018

Hello

Thank you for the component.
One problem tho: your dismissable flag only hides the X button, you can still dismiss it.

You can add in component.vue around line 186

        // Check dismiss callback result for prevention
        if (this.vuedals[localIndex].onDismiss() === false)
          return;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ValiDrv